Merged
Conversation
Added compute_metrics.py to the pipeline and removed distribution.py (Bitcoin Tor nodes are now redistributed directly in parse.py)
Functions now implemented in parse.py
Removed unused scripts from README and directory structure.
LadyChristina
requested changes
Mar 5, 2026
bitcoin/network_decentralization/metrics/concentration_ratio.py
Outdated
Show resolved
Hide resolved
LadyChristina
requested changes
Mar 16, 2026
Member
LadyChristina
left a comment
LadyChristina
left a comment
There was a problem hiding this comment.
Looks good overall but there are a couple changes I would suggest (see comments)
LadyChristina
approved these changes
Mar 18, 2026
Member
LadyChristina
left a comment
LadyChristina
left a comment
There was a problem hiding this comment.
Looks good overall. I flagged a couple minor issues that could be addressed, but generally happy for it to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added metric computation to the Bitcoin tool - Integrated redistribution of Tor nodes in parse.py instead of having it in a separate file - Removed unused scripts